Inconsistent behavior between dispatch and non-dispatch threads. When nxVersion is null on the dispatch thread, it returns null immediately without trying fallback methods. However, on non-dispatch threads, it attempts fallbacks via tryGetNxVersionFromNodeModules() and tryGetNxVersionFromPackageJson(). This creates unpredictable behavior where the same call returns different results depending on which thread it's called from.

If the dispatch thread case also needs to try fallbacks when nxVersion is null, it should wrap the fallback logic in ApplicationManager.getApplication().runReadAction<NxVersion?> or use invokeLater to avoid blocking the EDT:

return if (ApplicationManager.getApplication().isDispatchThread) {
    nxVersion ?: ApplicationManager.getApplication().runReadAction<NxVersion?> {
        tryGetNxVersionFromNodeModules() ?: tryGetNxVersionFromPackageJson()
    }
} else {
    nxVersion ?: ApplicationManager.getApplication().runReadAction<NxVersion?> {
        tryGetNxVersionFromNodeModules() ?: tryGetNxVersionFromPackageJson()
    }
}

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.